Review of Operators (part 1) #8512
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...when operators are changed.
…rs page ^^^ was missing. ^ and = had their precedence swapped.
"<" should come before ">", so <= before >>, <<< before >>>, <<~ before ~>>, and so on.
eksperimental
commented
Dec 12, 2018
eksperimental
commented
Dec 12, 2018
lib/elixir/pages/Operators.md
Outdated
Contributor
Author
There was a problem hiding this comment.
commas added before "then"
eksperimental
commented
Dec 12, 2018
lib/elixir/pages/Operators.md
Outdated
Contributor
Author
There was a problem hiding this comment.
missing operator added
eksperimental
commented
Dec 12, 2018
lib/elixir/pages/Operators.md
Outdated
Contributor
Author
There was a problem hiding this comment.
precedence corrected
eksperimental
commented
Dec 12, 2018
lib/elixir/pages/Operators.md
Outdated
Contributor
Author
There was a problem hiding this comment.
"strict" instead of "stricter"
josevalim
reviewed
Dec 12, 2018
eksperimental
force-pushed
the
operators
branch
from
8bc282b to
6df94eb
Compare
Contributor
Author
|
suggestions implemented! |
josevalim
approved these changes
Dec 12, 2018
fertapric
reviewed
Dec 12, 2018
eksperimental
force-pushed
the
operators
branch
from
6df94eb to
0da8ff6
Compare
fertapric
approved these changes
Dec 14, 2018
Member
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is part one (of two hopefully), broken into several commits to ease the reviewing