Add missing typespecs to Macro.underscore/1 and Macro.do_underscore/2 #8536
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MainShayne233
force-pushed
the
master
branch
4 times, most recently
from
b6192eb to
a02a838
Compare
MainShayne233
changed the title
MainShayne233
force-pushed
the
master
branch
from
a02a838 to
838dffd
Compare
josevalim
approved these changes
Dec 17, 2018
Member
josevalim
left a comment
josevalim
left a comment
There was a problem hiding this comment.
Hi @MainShayne233! We don't @spec private functions, so I removed that one and kept the public one. Thanks!
fertapric
approved these changes
Dec 17, 2018
Member
|
❤️ 💚 💙 💛 💜 |
Contributor
Author
|
@josevalim Awesome! Thanks for the assist-commit! Out of curiosity, what are the reasons to not |
Member
|
We use |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was poking around in the
Macromodule and realized these functions were missing@specs.