Remove Integer.to_string/1 and Integer.to_charlist/1 #8777
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are not needed, since they are covered by their /2 version.
Member
|
❤️ 💚 💙 💛 💜 |
michalmuskala
added a commit
that referenced
this pull request
Feb 7, 2019
This reverts commit 2622fd6.
Member
|
@eksperimental did you benchmark the change? |
Member
|
They seem to all be BIFs since OTP 21.3. |
Member
|
Ah, you're right. That still leaves quite a lot of supported versions with a potential performance degradation. |
Contributor
Author
|
I guess we should revert the PR and add annote to reapply it when 22 is the minimum supported version |
eksperimental
added a commit
to eksperimental-forks/elixir
that referenced
this pull request
May 15, 2019
…lang#8777)" This reverts commit 2622fd6.
Merged
Contributor
Author
|
Fixed |
josevalim
pushed a commit
that referenced
this pull request
Mar 29, 2021
They are not needed, since they are covered by their /2 version.
josevalim
pushed a commit
that referenced
this pull request
May 6, 2021
They are not needed, since they are covered by their /2 version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They are not needed, since they are covered by their /2 version.