Skip to content

Fixes #9081 by improving documentation of GenServer.server() type. #9082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fertapric merged 2 commits into from
May 27, 2019
Merged

Fixes #9081 by improving documentation of GenServer.server() type. #9082

fertapric merged 2 commits into from
May 27, 2019

Conversation

@Qqwy
Copy link
Contributor

@Qqwy Qqwy commented May 27, 2019 •
edited
Loading

Fixes #9081 by improving documentation of GenServer.server() type, as well as mentioning its possible values in the documentation of GenServer.cast.

@fertapric fertapric merged commit cddb455 into elixir-lang:master May 27, 2019
@fertapric
Copy link
Member

fertapric commented May 27, 2019

Thanks @Qqwy! 💜

@fertapric
Copy link
Member

fertapric commented May 27, 2019 •
edited
Loading

Oh! I just realized that name is defined as @type name :: atom | {:global, term} | {:via, module, term}, so the previous typespec was correct. The extra docs in cast/2 and t:server/0 are good though 🙂

@fertapric fertapric mentioned this pull request May 27, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@josevalim josevalim josevalim approved these changes

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Spec of GenServer.server() type is lacking information of :via-tuples

3 participants

@Qqwy @fertapric @josevalim