Fixed Path.absname to correctly handle UNC paths on Windows #9689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
absname was incorrectly converting `//host/path` to `/host/path` Added Windows-only Unit Tests for: * Path.absname for UNC path (fixed here) * Path.type for UNC path (was already correct, but not tested)
josevalim
approved these changes
Jan 4, 2020
Member
|
This will also accept mixed slashes: |
Contributor
Author
|
@ericmj yes, support for mixed slashes is intentional. Added Unit Tests. |
Member
|
Thank you! |
Contributor
Author
|
Thank you @ericmj!
|
Member
|
It will be backported to |
josevalim
pushed a commit
that referenced
this pull request
Jan 6, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
absname was incorrectly converting
//host/pathto/host/pathAdded Windows-only Unit Tests for: