Skip to content

Conversation

@eksperimental
Copy link
Contributor

This is part of #1009, but split in a separate commit to ease the reviewing process
It renames variables since it was a bit of a mess and confusing to work with.

@josevalim
Copy link
Member

So the reason why it is called autolink is because it is about autolink information. It makes sense to call it compiled in the Autolink module, but calling it compiled in that module misses important information once I pass it around, because it removes all context on what compiled is about. A better name would be compiled_autolink but that would take too long. So can we please keep the variable name as is? Thank you.

@josevalim josevalim closed this May 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants