Handle code blocks with and without language spec #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lib/ex_doc/formatter/html.ex
Outdated
Member
There was a problem hiding this comment.
I think we should move this inside each processor, no? :)
Member
Author
There was a problem hiding this comment.
Oh, you're definitely right, that makes more sense. I'll work on that! Thanks for your feedback 👍
Member
|
This is perfect. I think we should just move the logic specific to each markdown processor inside the markdown processor module and we will be good to go. :) |
This commit includes the following: * Improve `pretty_codeblocks` function to work with Hoedown and Pandoc * Add more tests for `pretty_codeblocks` * Delete duplicate code in `ExDoc.Markdown.to_html` * Avoid to run too many Regex.replace expressions * Add logic for pretty blocks in Hoedown and Pandoc
milmazz
force-pushed
the
pretty_code_blocks
branch
from
42518bd to
9dd34d6
Compare
Member
Author
|
@josevalim Do I need to do something else to complete this Pull Request? are you too busy right now to review this? I'm not in a hurry, I'm just curious, that's all! 👍 |
Member
|
@milmazz that's ok. please do ping me after changes :) otherwise I am not notified. |
josevalim
added a commit
that referenced
this pull request
Jun 2, 2015
Handle code blocks with and without language spec
Member
|
❤️ 💚 💙 💛 💜 |
Member
|
@milmazz ex doc needs love so your work is very appreciated, thank you! |
Member
Author
|
@josevalim Thanks! 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit includes the following:
pretty_codeblocksfunction to work with Hoedown and Pandocpretty_codeblocksExDoc.Markdown.to_htmlThis is a possible fix for #214