Make function signature be an H1 element #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@eksperimental you forgot to commit the new asset files. :) |
Member
|
Other than that, this looks great! ❤️ |
josevalim
approved these changes
Nov 13, 2018
Contributor
Author
|
Oops. I will when i get to the computer |
eksperimental
force-pushed
the
restructure_html
branch
from
0487bc9 to
a1c8d49
Compare
Contributor
Author
|
Have a look now |
Member
|
CI is still failing, can you please investigate @eksperimental? Thanks! |
eksperimental
force-pushed
the
restructure_html
branch
from
a1c8d49 to
66e2e70
Compare
eksperimental
changed the title
eksperimental
force-pushed
the
restructure_html
branch
from
66e2e70 to
c46f88b
Compare
Contributor
Author
|
Sorry, totatlly forgot to run |
josevalim
approved these changes
Nov 16, 2018
Member
|
❤️ 💚 💙 💛 💜 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #923