fix(engine): don't collect sibling scopes in Phoenix router#420
Merged
doorgan merged 1 commit intoelixir-lang:mainfrom Feb 20, 2026
Merged
fix(engine): don't collect sibling scopes in Phoenix router#420doorgan merged 1 commit intoelixir-lang:mainfrom
doorgan merged 1 commit intoelixir-lang:mainfrom
Conversation
We don't need to use Zipper here at all, as Ast.cursor_path contains all the ancestor scopes. This fixes collecting sibling scopes as ancestors, in extreme cases leading to exceeding max size of an atom.
mhanberg
pushed a commit
that referenced
this pull request
Feb 22, 2026
🤖 I have created a release *beep* *boop* --- ## [0.1.0-rc.1](v0.1.0-rc.0...v0.1.0-rc.1) (2026-02-22) ### Features * prompt user to fetch deps when they get out of sync ([#405](#405)) ([fc16ddc](fc16ddc)) ### Bug Fixes * build expert on latest nixpkgs ([#422](#422)) ([d3eb92c](d3eb92c)) * bump spitfire v0.3.7 ([#425](#425)) ([ce508c8](ce508c8)) * **engine:** don't collect sibling scopes in Phoenix router ([#420](#420)) ([b72bfc8](b72bfc8)) * **expert:** don't crash on missing root_uri ([#412](#412)) ([11ed716](11ed716)) * **forge:** progress message ordering ([#427](#427)) ([f3b9187](f3b9187)) * migrate expert runtime logging to OTP handlers ([#419](#419)) ([8f2dda5](8f2dda5)) * provide typespec docs on hover for private functions ([#407](#407)) ([79c5451](79c5451)) ### Miscellaneous Chores * release as 0.1.0-rc.1 ([6f5986e](6f5986e)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need to use Zipper here at all, as Ast.cursor_path contains all the ancestor scopes. This fixes collecting sibling scopes as ancestors, in extreme cases leading to exceeding max size of an atom.
Should fix #360, but in general improve hover etc. in
router.ex.