fix: honor month helper calendar options#10
Merged
kipcole9 merged 1 commit intoApr 25, 2026
Conversation
rubas
force-pushed
the
fix/month-helper-calendar-options
branch
4 times, most recently
from
6a3afdf to
bfdedaa
Compare
rubas
force-pushed
the
fix/month-helper-calendar-options
branch
from
bfdedaa to
a0f44e4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Localize.HTML.Monthaccepted a:calendaroption, but month labels were always read from Gregorian calendar data.This keeps the existing API shape: callers pass an Elixir calendar module, and
Calendar.ISOstill resolves to Gregorian labels. When a calendar module exposescldr_calendar_type/0, the helper uses that CLDR calendar for the month labels; otherwise it keeps the existing Gregorian fallback.The month list behavior is unchanged:
:monthscontrols which numbers are rendered.