Add support for custom highlight tag#23
Conversation
|
@msarava, are you still interested in contributing? Or do you prefer I take over this and change it myself? |
|
@tmbb just let me know what changes you need. I'll be glad to improve the PR. |
|
@msaraiva Just make the highlight tag either the first or the last argument to teh functions. I don't like having the |
|
@tmbb many thanks for merging this. BTW, Are you planning to release a new version anytime soon? We are looking forward to seeing this feature on hex so we can update Thanks again! |
| @group_highlight_js "lib/makeup/formatters/html/scripts/group_highlighter_javascript.js" |> File.read! | ||
|
|
||
| defp render_token(escaped_value, css_class, meta) do | ||
| defp render_token(escaped_value, css_class, highlight_tag, meta) do |
There was a problem hiding this comment.
I'd prefer if highlight_tag were wither the first or the last argument. Could you change it please?
|
I have released a new version |
|
Fantastic! Congrats on the v1.0.0 release! I think however we need a new |
|
@josevalim I have already released a new version, which an be incorporated into ExDoc. Maybe we should make use of the lexer discovery functionality now that it's stable? |
|
Oh yeah, that would be great! |
3 participants
This PR adds a new option
:highlight_tagtoMakeup.highlight_inner_html/2. I'm not sure this is the path you wanted me to take. Let me know if you have something else in mind.Closes #21 and #22.