Skip to content

feat: add window dilations #82

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 8, 2025
Merged

feat: add window dilations #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0df7a32
first iteration of window dilations implementation followin Torchx steps
Chapaman Oct 8, 2025
7070161
implemented window dilations on EMLX.window_op()
Chapaman Oct 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions lib/emlx/backend.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1342,8 +1342,6 @@ defmodule EMLX.Backend do
end

defp window_op(op, out, tensor, window_shape, opts) do
# TODO: window dilations can be implemented after we support internal padding
# in Nx.pad (we should have pad_internal as a shared defp)
tensor_rank = tuple_size(tensor.shape)

axes =
Expand All @@ -1356,7 +1354,20 @@ defmodule EMLX.Backend do
{low_pad, high_pad} = Enum.unzip(opts[:padding])
{device, _} = t_mx = from_nx(tensor)

{_device, pad_mx} =
window_dilations = opts[:window_dilations] || List.duplicate(1, tuple_size(window_shape))
interior_padding_config = Enum.map(window_dilations, &(&1 - 1))

{_device, zero_mx} = EMLX.scalar_tensor(0, :bool, device)

window =
1
|> EMLX.scalar_tensor(:bool, device)
|> EMLX.broadcast_to(window_shape)
|> interior_padding_mlx(zero_mx, interior_padding_config)

window_shape = EMLX.shape(window)

{device, pad_mx} =
case op do
:sum ->
EMLX.scalar_tensor(0, to_mlx_type(out.type), device)
Expand All @@ -1375,6 +1386,7 @@ defmodule EMLX.Backend do

padded_mx
|> sliding_window_view(EMLX.shape(padded_mx), window_shape, opts[:strides])
|> then(&EMLX.where(window, &1, {device, pad_mx}))
|> then(&apply(EMLX, op, [&1, axes, false]))
|> to_nx(out)
end
Expand Down
7 changes: 0 additions & 7 deletions test/emlx/nx_doctest_test.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,13 +47,6 @@ defmodule EMLX.Nx.DoctestTest do

@to_be_fixed [
:moduledoc,
# window_* do not support window_dilations yet
window_sum: 3,
window_max: 3,
window_min: 3,
window_product: 3,
window_mean: 3,
# missing support for inner padding
# MLX sorts NaNs lowest, Nx sorts them highest
argmin: 2,
argmax: 2,
Expand Down