Skip to content

fix(torchx): libtorch download for >=2.8 should not include cxx11 abi #1638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
polvalente merged 2 commits into from
Oct 27, 2025
Merged

fix(torchx): libtorch download for >=2.8 should not include cxx11 abi #1638

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
544499f
fix(torchx): libtorch download for 2.8 should not include cxx11 abi
polvalente Oct 27, 2025
0661499
chore: uncomment line
polvalente Oct 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 17 additions & 6 deletions torchx/mix.exs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,26 +74,33 @@ defmodule Torchx.MixProject do
end

defp libtorch_config() do
target = System.get_env("LIBTORCH_TARGET", "cpu")
version = System.get_env("LIBTORCH_VERSION", "2.9.0")
env_dir = System.get_env("LIBTORCH_DIR")

# Supported targets for each LibTorch version:
valid_targets =
{has_cxx11_abi, valid_targets} =
case Version.parse(version) do
{:ok, parsed} ->
cond do
Version.match?(parsed, "< 2.8.0") ->
["cpu", "cu118", "cu126", "cu128"]
{true, ["cpu", "cu118", "cu126", "cu128"]}

Version.match?(parsed, "< 2.9.0") ->
["cpu", "cu126", "cu129"]
{false, ["cpu", "cu126", "cu129"]}

true ->
["cpu", "cu126", "cu128", "cu130"]
{false, ["cpu", "cu126", "cu128", "cu130"]}
end

_ ->
valid_targets
raise ArgumentError, "Unsupported LibTorch version"
end

%{
# Latest LibTorch does not support cxx11-abi
# but older versions still do
has_cxx11_abi: has_cxx11_abi,
valid_targets: valid_targets,
target: target,
version: version,
Expand Down Expand Up @@ -147,7 +154,11 @@ defmodule Torchx.MixProject do
url =
case :os.type() do
{:unix, :linux} ->
"https://download.pytorch.org/libtorch/#{libtorch_config.target}/libtorch-cxx11-abi-shared-with-deps-#{libtorch_config.version}%2B#{libtorch_config.target}.zip"
if libtorch_config.has_cxx11_abi do
"https://download.pytorch.org/libtorch/#{libtorch_config.target}/libtorch-cxx11-abi-shared-with-deps-#{libtorch_config.version}%2B#{libtorch_config.target}.zip"
else
"https://download.pytorch.org/libtorch/#{libtorch_config.target}/libtorch-shared-with-deps-#{libtorch_config.version}%2B#{libtorch_config.target}.zip"
end

{:unix, :darwin} ->
case List.to_string(:erlang.system_info(:system_architecture)) do
Expand Down