Merged
Conversation
polvalente
reviewed
Mar 2, 2026
Contributor
polvalente
left a comment
polvalente
left a comment
There was a problem hiding this comment.
This is basically in the right direction! I gotta check if there's more code we can share between the cuda and host paths.
exla/Makefile
Outdated
|
|
||
| SOURCES = $(EXLA_DIR)/exla.cc $(EXLA_DIR)/exla_client.cc $(EXLA_DIR)/exla_mlir.cc $(EXLA_DIR)/ipc.cc | ||
| SOURCES += $(wildcard $(EXLA_DIR)/custom_calls/*.cc) | ||
| SOURCES += $(filter-out $(EXLA_DIR)/custom_calls/runtime_callback_cuda.cc,$(wildcard $(EXLA_DIR)/custom_calls/*.cc)) |
Contributor
There was a problem hiding this comment.
There's gotta be a better way than this. Let's leave this for last, though.
exla/Makefile
Outdated
| OBJECTS += $(EXLA_CACHE_OBJ_DIR)/custom_calls/runtime_callback_cuda.o | ||
| $(EXLA_CACHE_OBJ_DIR)/custom_calls/runtime_callback_cuda.o: $(EXLA_DIR)/custom_calls/runtime_callback_cuda.cc $(HEADERS) | ||
| @ mkdir -p $(EXLA_CACHE_OBJ_DIR)/custom_calls | ||
| $(NVCC) $(NVCCFLAGS) -c $< -o $@ |
Contributor
There was a problem hiding this comment.
I thought we wouldn't have to use gpu stuff for our custom calls
Co-authored-by: Paulo Valente <16843419+polvalente@users.noreply.github.com>
polvalente
approved these changes
Mar 6, 2026
blasphemetheus
added a commit
to blasphemetheus/nx
that referenced
this pull request
Mar 11, 2026
The CUDA runtime_call handler (added in elixir-nx#1677) still used the old CallbackServer approach. Update it to register callbacks in the Outfeed struct and use the 4-arg InvokeRuntimeCallback (no PID). Since the host and CUDA handlers are now identical, merge them into a single clause with a `when platform in [:host, :cuda]` guard. Also update runtime_callback_cuda.cc to match the new bridge signature. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1031