Rewrite protocol to https when x-forwarded-proto is wss#1302
Merged
josevalim merged 1 commit intoelixir-plug:mainfrom Mar 16, 2026
Merged
Rewrite protocol to https when x-forwarded-proto is wss#1302josevalim merged 1 commit intoelixir-plug:mainfrom
josevalim merged 1 commit intoelixir-plug:mainfrom
Conversation
Member
|
💚 💙 💜 💛 ❤️ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Traefik proxy set the value
wsorwssfor theX-Forwarded-Protoheader when the http(s) request is a websocket. The underlying code is here: https://github.com/traefik/traefik/blob/67c64ed9b25fbb90f1086977a62827133a7aa01b/pkg/middlewares/forwardedheaders/forwarded_header.go#L177-L192On production deployment, when the ssl plug is used to force https and a websocket request is made, the request is always redirected to the https version.
I found 2 case of this problem on the forum:
Not sure if we want to support this special case for Traefik, I'm opening this to start a discussion. As some point it was discussed on Traefik side: traefik/traefik#6388