Fix repeated enum field generate [[]] into typespec #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wingyplus
commented
Dec 23, 2020
| def enum_to_spec(:TYPE_SINT64), do: "integer" | ||
| def enum_to_spec(_), do: "any" | ||
| def enum_to_spec(:TYPE_MESSAGE, type, true = _repeated), do: "#{type}.t" | ||
| def enum_to_spec(:TYPE_MESSAGE, type, true = _repeated), do: "[#{type}.t]" |
Contributor
Author
There was a problem hiding this comment.
I just see that message type doesn't add | nil into generated type. Should we need to add into this patch?
whatyouhide
reviewed
Apr 15, 2021
Collaborator
whatyouhide
left a comment
whatyouhide
left a comment
There was a problem hiding this comment.
Hey @wingyplus , sorry for the long wait! Could you rebase this on the master branch?
|
|
||
| defp fmt_type(%{label: "repeated", type_enum: type_enum, type: type}) do | ||
| "[#{type_to_spec(type_enum, type, true)}]" | ||
| "#{type_to_spec(type_enum, type, true)}" |
Collaborator
There was a problem hiding this comment.
Can this be 👇 now?
Suggested change
| "#{type_to_spec(type_enum, type, true)}" | |
| type_to_spec(type_enum, type, true) |
Removing [] out of Protobuf.Protoc.Generator.Message.fmt_type/1 and add [] into Protobuf.TypeUtil.enum_to_spec/3 when TYPE_MESSAGE is match alongs with repeated true. Fixes elixir-protobuf#132
wingyplus
force-pushed
the
fix-enum-repeated
branch
from
1f61714 to
61e50f9
Compare
Contributor
Author
|
@whatyouhide thank you for reviewing my changes. The PR already rebase and apply your suggestion. Please kindly review again. |
This was referenced Oct 16, 2021
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing
[]out ofProtobuf.Protoc.Generator.Message.fmt_type/1andadd
[]intoProtobuf.TypeUtil.enum_to_spec/3whenTYPE_MESSAGEis matchalongs with repeated true.
Fixes #132