Fix typespec generation for repeated fields #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
britto
commented
Oct 16, 2021
| def enum_to_spec(:TYPE_SFIXED64), do: "integer" | ||
| def enum_to_spec(:TYPE_SINT32), do: "integer" | ||
| def enum_to_spec(:TYPE_SINT64), do: "integer" | ||
| def enum_to_spec(_), do: "any" |
Collaborator
Author
There was a problem hiding this comment.
TYPE_GROUP was the only one missing, added above ☝️. Removing this catch-all clause will make the library more strict (and brittle) in regards to the unknown future. As an alternative, we could add it back but raise a warning instead.
britto
commented
Oct 16, 2021
Comment on lines
-39
to
-42
| def enum_to_spec(:TYPE_MESSAGE, type, true = _repeated), do: "[#{type}.t]" | ||
| def enum_to_spec(:TYPE_MESSAGE, type, false = _repeated), do: "#{type}.t | nil" | ||
| def enum_to_spec(:TYPE_ENUM, type, true = _repeated), do: "[#{type}.t]" | ||
| def enum_to_spec(:TYPE_ENUM, type, false = _repeated), do: "#{type}.t" |
Collaborator
Author
There was a problem hiding this comment.
The label (optional, required or repeated) logic didn't seem to fit well in here, so I moved it up to the caller.
britto
commented
Oct 16, 2021
britto
force-pushed
the
fix-repeated-and-optional-typespecs
branch
from
76b4ed8 to
54f1397
Compare
Collaborator
Collaborator
Author
britto
force-pushed
the
fix-repeated-and-optional-typespecs
branch
3 times, most recently
from
d4f7c42 to
922c823
Compare
Collaborator
Author
|
Rebased ✅
|
ericmj
reviewed
Oct 20, 2021
Optional fields types were not including `nil` as a possible value, now they do. Repeated scalar fields were not getting wrapped in brackets, now they are.
britto
force-pushed
the
fix-repeated-and-optional-typespecs
branch
from
922c823 to
89e49fb
Compare
Skip the ` | nil` on scalar fields, even when optional.
ericmj
reviewed
Oct 21, 2021
Optional when type is message and required otherwise.
britto
changed the title
ericmj
approved these changes
Oct 21, 2021
Collaborator
|
Nice job @britto, thanks! 💟 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scalars were no longer getting wrapped in brackets since #140 (See #173), now they are. Also add parentheses to remote type calls with no arguments (
.t->.t()).