Skip to content

chore(mint): strengthen mode regression coverage#841

Merged
yordis merged 1 commit intomasterfrom
yordis/test-mint-mode-coverage
Apr 18, 2026
Merged

chore(mint): strengthen mode regression coverage#841
yordis merged 1 commit intomasterfrom
yordis/test-mint-mode-coverage

Conversation

@yordis
Copy link
Copy Markdown
Member

@yordis yordis commented Apr 18, 2026

  • keep the Mint adapter regression net explicit after the passive-default fix changed the most failure-prone path
  • make active and passive reused-connection expectations visible so future changes do not silently drop one side of the behavior matrix
  • preserve confidence in follow-up Mint changes by asserting the closed-connection edge cases in one place

Copilot AI review requested due to automatic review settings April 18, 2026 07:41
@cursor
Copy link
Copy Markdown

cursor Bot commented Apr 18, 2026

PR Summary

Low Risk
Test-only changes that expand coverage around Mint adapter modes and connection reuse, with no production logic changes. Low risk aside from potential CI flakiness if assumptions about Mint errors vary across environments.

Overview
Strengthens Mint adapter regression coverage by adding a full mode: :passive test matrix for body_as (:plain, :stream, :chunks).

Splits connection-reuse tests into active vs passive suites, adds a shared closed-connection error assertion, and refactors repeated request/reuse setup into helper functions to make the behavior matrix explicit.

Reviewed by Cursor Bugbot for commit 19ab5ba. Bugbot is set up for automated code reviews on this repo. Configure here.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR strengthens regression coverage around Tesla’s Mint adapter connection mode handling, especially after recent changes to passive defaults, by making active vs passive behavior explicit in tests and expanding coverage for reused-connection edge cases.

Changes:

  • Add explicit mode: :passive test coverage for body_as variants (:plain, :stream, :chunks).
  • Split “reusing connection” coverage into separate “reusing active connection” and “reusing passive connection” describes.
  • Refactor reused-connection assertions into helper functions to reduce duplication and centralize closed-connection expectations.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread test/tesla/adapter/mint_test.exs Outdated
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
@yordis yordis force-pushed the yordis/test-mint-mode-coverage branch from 64cd296 to 19ab5ba Compare April 18, 2026 07:46
@yordis yordis requested a review from Copilot April 18, 2026 07:52
@yordis yordis merged commit daec639 into master Apr 18, 2026
12 checks passed
@yordis yordis deleted the yordis/test-mint-mode-coverage branch April 18, 2026 07:55
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants