chore(mint): strengthen mode regression coverage#841
Conversation
yordis
commented
Apr 18, 2026
- keep the Mint adapter regression net explicit after the passive-default fix changed the most failure-prone path
- make active and passive reused-connection expectations visible so future changes do not silently drop one side of the behavior matrix
- preserve confidence in follow-up Mint changes by asserting the closed-connection edge cases in one place
PR SummaryLow Risk Overview Splits connection-reuse tests into active vs passive suites, adds a shared closed-connection error assertion, and refactors repeated request/reuse setup into helper functions to make the behavior matrix explicit. Reviewed by Cursor Bugbot for commit 19ab5ba. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Pull request overview
This PR strengthens regression coverage around Tesla’s Mint adapter connection mode handling, especially after recent changes to passive defaults, by making active vs passive behavior explicit in tests and expanding coverage for reused-connection edge cases.
Changes:
- Add explicit
mode: :passivetest coverage forbody_asvariants (:plain,:stream,:chunks). - Split “reusing connection” coverage into separate “reusing active connection” and “reusing passive connection” describes.
- Refactor reused-connection assertions into helper functions to reduce duplication and centralize closed-connection expectations.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
64cd296 to
19ab5ba
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.