Conversation
yordis
commented
Apr 22, 2026
- make the URL contract explicit for callers discussing malformed request targets in Tesla does not properly encode URLs #798
- keep encoding, validation, and normalization decisions with applications instead of baking adapter-specific semantics into Tesla
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
PR SummaryLow Risk Overview Explicitly notes that Tesla won’t validate/normalize/percent-encode URL paths and that middleware may rewrite Reviewed by Cursor Bugbot for commit e1d1449. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Pull request overview
Clarifies the ownership/contract of Tesla.Env.url to set expectations around URL validity/encoding (context: malformed request targets discussed in #798), keeping encoding/normalization decisions in application code rather than Tesla.
Changes:
- Add
@typedocfort:Tesla.Env.url/0describing it as a request URL or request target. - Document that callers should provide a valid, already-encoded value and that Tesla won’t validate/normalize malformed input.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>
Signed-off-by: Yordis Prieto <yordis.prieto@gmail.com>