fix: don't crash on charlist with pure interpolation#133
Open
moxley wants to merge 1 commit into
Open
Conversation
The :list_string non-interpolation clause of parse_string/1 was missing
the `when is_binary(string)` guard that the parallel :bin_string clause
has. When the tokenizer emits a single-element token list for a charlist
that contains only an interpolation (e.g. '#{x}'), the unguarded clause
matches and calls String.to_charlist/1 on the interpolation-segment
tuple, raising FunctionClauseError.
Charlists with surrounding text ('foo#{x}bar') were unaffected because
their token list has multiple elements and falls through to the
interpolation-aware clause.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
:list_stringnon-interpolation clause ofparse_string/1was missing thewhen is_binary(string)guard that the parallel:bin_stringclause has. When the tokenizer emits a single-element token list for a charlist that contains only an interpolation (e.g.'#{x}'), the unguarded clause matches and callsString.to_charlist/1on the interpolation-segment tuple, raisingFunctionClauseError.Charlists with surrounding text (
'foo#{x}bar') were unaffected because their token list has multiple elements and falls through to the interpolation-aware clause.Fixes #132