fix: extract newlines only from newline carrying tokens #86
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were assuming that a third integer element in the token tuple were
always newlines, but they can sometimes be other things, like a
delimiter character codepoint.
This caused the `:newlines` metadata to be attached to nodes that should
not have it. This caused a mismatch between what Spitfire produces and
what the Elixir parser produces.
`%Foo{"ok": 1}` was the smallest example I found to trigger this bug.
doorgan
force-pushed
the
doorgan/newlines
branch
from
f93294c to
5446782
Compare
doorgan
commented
Jan 30, 2026
| end | ||
|
|
||
| defp current_newlines(%{current_token: {_token, {_line, _col, newlines}, _}}) when is_integer(newlines) do | ||
| @newline_carrying_tokens [ |
Contributor
Author
There was a problem hiding this comment.
I got this list by inspecting the tokenizer. Some tokens are handled directly(eg eol), most of them are handled indirectly by handle_op where previous_was_eol embeds the newlines into them.
mhanberg
pushed a commit
that referenced
this pull request
Feb 4, 2026
🤖 I have created a release *beep* *boop* --- ## [0.3.2](v0.3.1...v0.3.2) (2026-02-01) ### Bug Fixes * associativity in bracketless kw list ([#89](#89)) ([91b5d5b](91b5d5b)) * extract newlines only from newline carrying tokens ([#86](#86)) ([edba800](edba800)) * improve handling of matched/unmatched expressions ([#88](#88)) ([dd45cb1](dd45cb1)) * keyword list associativity ([#85](#85)) ([a7d2a54](a7d2a54)) * parse ellipsis_op as unary operator ([#83](#83)) ([e86f1f4](e86f1f4)) * rearrange `!(left) in right` ([#91](#91)) ([fae2579](fae2579)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were assuming that a third integer element in the token tuple were always newlines, but they can sometimes be other things, like a delimiter character codepoint.
This caused the
:newlinesmetadata to be attached to nodes that should not have it. This caused a mismatch between what Spitfire produces and what the Elixir parser produces.%Foo{"ok": 1}was the smallest example I found to trigger this bug.