Skip to content

Hackney 4 compatibility#116

Merged
mhanberg merged 6 commits into
elixir-wallaby:masterfrom
phinnaeus:hackney-4-upgrade
Jun 5, 2026
Merged

Hackney 4 compatibility#116
mhanberg merged 6 commits into
elixir-wallaby:masterfrom
phinnaeus:hackney-4-upgrade

Conversation

@phinnaeus
Copy link
Copy Markdown
Contributor

@phinnaeus phinnaeus commented Jun 5, 2026

Summary

  • Add a second "legacy" lock file so that we can keep testing Hackney 1.x
  • Update CI to run tests against both lock files
  • fixes for tests, formatter, etc

Fixes #115

Things I'd like to fix in a separate PR

  • integration_tests job is failing even without my changes, could be fixed but it's not trivial
  • New credo checks -- allow running credo on the modern/default lockfile
  • update checkout and cache jobs to v5

@phinnaeus phinnaeus force-pushed the hackney-4-upgrade branch from 7f77af9 to 73b4797 Compare June 5, 2026 23:17
phinnaeus added 3 commits June 6, 2026 09:28
Single-quoted charlist literals are deprecated on modern Elixir, and
the ~c sigil is unavailable on Elixir 1.8. String.to_charlist/1
compiles warning-free on every supported version.
@phinnaeus phinnaeus force-pushed the hackney-4-upgrade branch from 73b4797 to ae9eb9d Compare June 5, 2026 23:31
phinnaeus added 2 commits June 6, 2026 09:38
Legacy Elixir/OTP entries move into hexpm/elixir containers because
erlef/setup-beam can no longer install OTP < 24.2 on current
GitHub-hosted runners. A new Elixir 1.19/OTP 28 entry exercises the
default lockfile with hackney 4.
Comment thread test/support/integration_testing/test_pages/server.ex
@phinnaeus phinnaeus force-pushed the hackney-4-upgrade branch from ae9eb9d to aabc2ff Compare June 5, 2026 23:46
@mhanberg mhanberg merged commit de3cfb3 into elixir-wallaby:master Jun 5, 2026
11 of 17 checks passed
@mhanberg
Copy link
Copy Markdown
Member

mhanberg commented Jun 5, 2026

thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Hackney 4.x?

2 participants