Skip to content

Add peer_left message to signaling server #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Add peer_left message to signaling server #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92c5d0e
Change WS timeout to default 60s
LVala Jan 4, 2024
204bb42
Add `peer_left` message to signaling server
LVala Jan 4, 2024
3cea2a5
Update README.md
LVala Jan 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion signalling_server/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,4 +23,12 @@ sock = new WebSocket("ws://localhost:4000/websocket")

The `role` field is a role a peer that received info JSON should use to avoid role conflict.

3. Send any message via WS, it will be forwarded to the other side.
3. Send any message via WS, it will be forwarded to the other side.

4. When a peer leaves, the other one receives JSON message:

```json
{
"type": "peer_left"
}
```
8 changes: 8 additions & 0 deletions signalling_server/lib/room.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,8 +74,16 @@ defmodule SignallingServer.Room do

state =
if ref == state.p1_ref do
if state.p2 do
send(state.p2, {:forward, Jason.encode!(%{type: "peer_left"})})
end

%{state | p1_ref: nil, p1: nil}
else
if state.p1 do
send(state.p1, {:forward, Jason.encode!(%{type: "peer_left"})})
end

%{state | p2_ref: nil, p2: nil}
end

Expand Down
2 changes: 1 addition & 1 deletion signalling_server/lib/router.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ defmodule SignallingServer.Router do

get "/websocket" do
conn
|> WebSockAdapter.upgrade(SignallingServer.PeerHandler, [], timeout: 2_000)
|> WebSockAdapter.upgrade(SignallingServer.PeerHandler, [], [])
|> halt()
end

Expand Down