Skip to content

Conversation

@gBillal
Copy link
Collaborator

@gBillal gBillal commented Feb 5, 2025

I updated the audio sample format in reader to accept the ffmpeg naming too.

@gBillal gBillal requested a review from mickel8 February 5, 2025 07:17
@codecov
Copy link

codecov bot commented Feb 5, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 77.65%. Comparing base (029ee0d) to head (2b202ba).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
lib/xav/frame.ex 20.00% 8 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           master      #33       +/-   ##
===========================================
- Coverage   88.09%   77.65%   -10.44%     
===========================================
  Files           6        7        +1     
  Lines          84       94       +10     
===========================================
- Hits           74       73        -1     
- Misses         10       21       +11     
Files with missing lines Coverage Δ
lib/xav/decoder.ex 80.00% <ø> (ø)
lib/xav/reader.ex 91.42% <ø> (ø)
lib/xav/frame.ex 42.85% <20.00%> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d04abef...2b202ba. Read the comment docs.

@gBillal gBillal merged commit 6a2bea3 into master Feb 5, 2025
7 checks passed
@gBillal
Copy link
Collaborator Author

gBillal commented Feb 5, 2025

I'm merging this, if you have any issue, I'll fix them.

@gBillal gBillal deleted the consistent-audio-format branch February 5, 2025 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants