Remove Enum.fetch usage for MapSet#255
Merged
iamvery merged 1 commit intoelixirkoans:masterfrom Nov 9, 2020
Merged
Conversation
Collaborator
|
Good point. I see we call out the 33-element distinction a little further down. I think the purpose of the example is to set the stage for comparison and contrast with lists. Perhaps we should use Enum#member? instead. What do you think? |
Contributor
Author
|
IMHO, sets are not similar to lists, so comparison is not necessary here. And we shouldn't teach to newbies about implementation details something like magic number 32, which might change in future release. |
Collaborator
|
That's fair. I don't think the removal here is taking anything away. Thanks for the contribution! |
w0rd-driven
pushed a commit
to w0rd-driven/elixir-koans
that referenced
this pull request
Jul 12, 2021
Remove Enum.fetch usage for MapSet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enum.fetch(@set, 0)usage should be discouraged as it only works for MapSet created with list size < 32.So I think that koan should be removed.