Change protocol examples#256
Merged
ukutaht merged 1 commit intoelixirkoans:masterfrom Nov 9, 2020
Merged
Conversation
jechol
force-pushed
the
enhance/protocol
branch
from
00bda2c to
93c490c
Compare
Collaborator
|
I don't have a strong opinion about this. @ukutaht @felipesere do you have any thoughts? |
Collaborator
|
I think the PR does make the example easier to understand. I think we should merge it |
Contributor
Author
|
@ukutaht Could you approve this? |
Collaborator
|
@jechol merged! |
w0rd-driven
pushed a commit
to w0rd-driven/elixir-koans
that referenced
this pull request
Jul 12, 2021
Change protocol examples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think when struct S implements protocol P, we can say S is P or S has trait of P.
For example, List implements Enumerable and we can say List is Enumerable.
In current example, Musician implements School, but we can't say Musician is School.
I think better abstraction where Musician, Dancer belongs to and Baker doesn't is Artist.