ci(openvino): drop GPU matrix variant to fix workflow parse error#20
Merged
Conversation
The previous PR's job-level `if:` referencing both `matrix.variant` and `inputs.force_self_hosted` left build-openvino.yml in a state GitHub Actions rejected as 'workflow file issue', so no openvino runs were launching at all on c68b838. Simplify: remove the GPU variant from the matrix entirely. The GPU variant targeted a `[self-hosted, Linux, Intel, OpenVINO]` runner that doesn't exist in the elizaOS org, so it had no business running on every push/PR. The CPU variant on ubuntu-24.04 continues to provide build + ctest coverage for ggml-openvino. Re-introduce a GPU job (or a separate dedicated workflow gated on workflow_dispatch) once a self-hosted Intel runner is registered.
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR #19's openvino gating used a job-level
if: ${{ matrix.variant != 'gpu' || (github.event_name == 'workflow_dispatch' && inputs.force_self_hosted) }}, which GitHub Actions rejected as a 'workflow file issue', so the openvino workflow stopped launching at all onc68b838e.Simplify: remove the GPU matrix variant entirely. It targeted
[self-hosted, Linux, Intel, OpenVINO]— a runner the elizaOS org doesn't have — so there was no value in keeping it around. The CPU variant onubuntu-24.04continues to build + ctestggml-openvinoon every push/PR. Re-introduce a GPU job (or a separate dedicated workflow gated onworkflow_dispatch) once a self-hosted Intel runner is registered.