Skip to content

fix: logger compatibility#12

Merged
0xbbjoker merged 1 commit into1.xfrom
fix/logger-compatibility
Aug 8, 2025
Merged

fix: logger compatibility#12
0xbbjoker merged 1 commit into1.xfrom
fix/logger-compatibility

Conversation

@0xbbjoker
Copy link
Copy Markdown
Contributor

@0xbbjoker 0xbbjoker commented Aug 8, 2025

Fixing logger issue.

Summary by CodeRabbit

  • Style

    • Standardized string formatting to use single quotes throughout the app.
    • Improved consistency and readability of logging messages.
    • Minor whitespace and formatting adjustments for better code clarity.
  • Chores

    • Updated package version to 1.0.10.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Aug 8, 2025

Walkthrough

The changes consist of formatting and stylistic updates across several source files, focusing on consistent string quoting, improved logging structure, and minor whitespace adjustments. No functional, behavioral, or public API changes were introduced. Additionally, the package.json version was incremented from "1.0.9" to "1.0.10".

Changes

Cohort / File(s) Change Summary
Version Bump
package.json
Updated the version field from "1.0.9" to "1.0.10".
Stylistic and Logging Consistency
src/messageManager.ts, src/service.ts, src/tests.ts
Standardized single-quoted strings, improved structured error logging, and made minor formatting and whitespace adjustments. No logic or API changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Poem

A rabbit hops through code so neat,
With quotes now single, logs complete.
The version hops up, just a smidge—
No logic changed across the bridge.
Whitespace trimmed, all tidy and bright,
This code review’s a pure delight!
🐇✨

Note

🔌 MCP (Model Context Protocol) integration is now available in Early Access!

Pro users can now connect to remote MCP servers under the Integrations page to get reviews and chat conversations that understand additional development context.

✨ Finishing Touches
  • 📝 Generate Docstrings
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/logger-compatibility

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@0xbbjoker 0xbbjoker merged commit 54f8006 into 1.x Aug 8, 2025
1 of 2 checks passed
Copy link
Copy Markdown
Contributor

@coderabbitai coderabbitai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🧹 Nitpick comments (3)
src/messageManager.ts (2)

104-105: Use consistent logger instead of console.error

All other error paths now leverage logger.error. Keep consistency (and transport formatting) by replacing this direct console call.


311-313: messageId lacks explicit UUID typing

Other identifiers are cast (as UUID) for compile-time safety. Do the same here to avoid widening to any/string.

- const messageId = createUniqueUuid(this.runtime, message?.message_id?.toString());
+ const messageId = createUniqueUuid(
+   this.runtime,
+   message?.message_id?.toString()
+ ) as UUID;
src/service.ts (1)

73-75: Prefer structured error logging here as well

Most of the file now passes the error object first, then the message.
For consistency (and easier log parsing), consider:

- logger.error(
-   `Error initializing Telegram bot: ${error instanceof Error ? error.message : String(error)}`
- );
+ logger.error(
+   { error },
+   'Error initializing Telegram bot'
+ );
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
Cache: Disabled due to data retention organization setting
Knowledge Base: Disabled due to data retention organization setting

📥 Commits

Reviewing files that changed from the base of the PR and between edaa711 and c1f20ae.

📒 Files selected for processing (4)
  • package.json (1 hunks)
  • src/messageManager.ts (26 hunks)
  • src/service.ts (12 hunks)
  • src/tests.ts (3 hunks)
🧰 Additional context used
🧬 Code Graph Analysis (1)
src/tests.ts (1)
src/types.ts (1)
  • TelegramContent (8-11)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Cursor Bugbot
🔇 Additional comments (2)
package.json (1)

3-3: Version bump looks good

No further issues spotted.

src/tests.ts (1)

242-242: Structured logging approved

Passing the error object separately aligns with the new logging style.

Comment thread src/messageManager.ts
Comment on lines +149 to 151
await this.sendMedia(ctx, attachment.url, mediaType, attachment.description);
});
return [];
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Asynchronous map result is not awaited

content.attachments.map(async …) fires sendMedia in the background, but sendMessageInChunks immediately returns [].
Callers can’t know when media sending finished and unhandled rejections may surface.

- content.attachments.map(async (attachment: Media) => {
+ await Promise.all(
+   content.attachments.map(async (attachment: Media) => {- });
+   })
+ );
🤖 Prompt for AI Agents
In src/messageManager.ts around lines 149 to 151, the asynchronous map over
content.attachments calls sendMedia but does not await the resulting promises,
causing sendMessageInChunks to return immediately without waiting for media
sending to complete. To fix this, collect the promises returned by the async map
and await them using Promise.all before returning, ensuring callers know when
all media sending has finished and preventing unhandled rejections.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant