-
-
Notifications
You must be signed in to change notification settings - Fork 0
Fix or suppress (where appropriate) compilation issues with test files for clang-tidy analysis on Windows #129
Copy link
Copy link
Closed
Labels
bugSomething isn't workingSomething isn't workingci-cdRelates to CI/CD for the projectRelates to CI/CD for the projectcmakeApplicable to issues that are relavent to the CMake buildApplicable to issues that are relavent to the CMake builddocumentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requeststatic-analysisAn issue related to a static analysis resultAn issue related to a static analysis resulttest-suiteRelating to TestCPP TestSuiteRelating to TestCPP TestSuitetestingRelates to issues with and/or enhancement of testing for the project's codeRelates to issues with and/or enhancement of testing for the project's code
Milestone
Metadata
Metadata
Assignees
Labels
bugSomething isn't workingSomething isn't workingci-cdRelates to CI/CD for the projectRelates to CI/CD for the projectcmakeApplicable to issues that are relavent to the CMake buildApplicable to issues that are relavent to the CMake builddocumentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requeststatic-analysisAn issue related to a static analysis resultAn issue related to a static analysis resulttest-suiteRelating to TestCPP TestSuiteRelating to TestCPP TestSuitetestingRelates to issues with and/or enhancement of testing for the project's codeRelates to issues with and/or enhancement of testing for the project's code
Some issues came up when configuring the build to scan test files as well.
I'm quite surprised these issues were not discovered previously given how much I've used and tested the library.
There were doc comment issues, and a number of other issues.
I am about ready to create a few PRs for these things that I'm working on.
I have tested all the CMakePresets again, including the clean builds, and everything appears to be working; there are still a huge number of clang-tidy issues to address (approximately 257; StaticAnalysis is limited by the GH PR comment limit which allows the first ~190).
Especially in the realm of IWYU.
That is going to require significant effort to figure out how I'm going to work through those issues.