🐛 Fix multipart version comparison#1
Open
hbrooks wants to merge 2 commits into
Open
Conversation
Use numeric version parsing instead of string comparison so valid python-multipart versions like 0.0.100 are not treated as older than 0.0.12. Add regression tests for the multipart check and the version parser helper.
Make the 0.0.100 regression test fail on master by removing multipart fallback, and move _version_str_to_tuple tests to test_dependencies_utils.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Originally PR fastapi#15226 in fastapi/fastapi by @Esubaalew