This repository was archived by the owner on May 5, 2020. It is now read-only.
Task Native.WebSocket.close always succeeds with Maybe BadClose #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The type is annotated as
closeWith : Int -> String -> WebSocket -> Task x (Maybe BadClose)
closeWith = Native.WebSocket.close
But the native code was written as when the type would have been:
closeWith : Int -> String -> WebSocket -> Task BadClose ()
closeWith = Native.WebSocket.close
ThomasWeiser
force-pushed
the
fix-close-result
branch
from
f8ae0d6 to
05d1482
Compare
Contributor
|
The annotation is the intended way. Can we make the JS match that. |
Contributor
|
Oh, I think that was the intent! I'll take a look. |
Contributor
|
Thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The type is annotated as
But the native code was written as if the type would have been: