Fix Float.Extra.aboutEqual behaviour with infinities #51
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fix comparison so that it does not treat positive infinity as equal to negative infinity - Add some tests to check this - For good measure, test to make sure comparisons against NaN also behave as expected (always return false) - Tweak test code style to use Float.Extra.aboutEqual qualified like everything else
miniBill
approved these changes
Mar 19, 2024
gampleman
approved these changes
Mar 20, 2024
Collaborator
gampleman
left a comment
gampleman
left a comment
There was a problem hiding this comment.
Thanks, greatly appreciated!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a precursor to #49 - as I started looking at the code to make sure
aboutEqualandequalWithinhad consistent behaviour I noticed thataboutEqualcurrently treats positive and negative infinity as equal! (SinceisInfinitereturns true for both.)Float.Extra.aboutEqualqualified like everything else