Skip to content

update submodules#206

Merged
MrGuin merged 1 commit intoeloqdata:mainfrom
MrGuin:ddl_log_ng_leader
Sep 23, 2025
Merged

update submodules#206
MrGuin merged 1 commit intoeloqdata:mainfrom
MrGuin:ddl_log_ng_leader

Conversation

@MrGuin
Copy link
Collaborator

@MrGuin MrGuin commented Sep 23, 2025

Summary by CodeRabbit

  • Chores
    • Updated internal modules to the latest revisions for log and transaction services. No changes to features, behavior, or public interfaces.

@coderabbitai
Copy link

coderabbitai bot commented Sep 23, 2025

Walkthrough

Updates submodule pointers for two ELOQ modules: src/mongo/db/modules/eloq/log_service and src/mongo/db/modules/eloq/tx_service. No code, API, tests, or control flow changes are included.

Changes

Cohort / File(s) Summary
ELOQ log_service submodule
src/mongo/db/modules/eloq/log_service
Update submodule reference from b85326f to eec3b2b; no functional or API changes.
ELOQ tx_service submodule
src/mongo/db/modules/eloq/tx_service
Update submodule commit pointer; no functional or API changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested labels

trigger-ci

Suggested reviewers

  • thweetkomputer

Poem

I twitch my whiskers at each tiny ref,
A hop, a skip—submodules set.
No code to chew, no tests to fret,
Just tidy trails where commits are met.
Thump! CI runs—my carrot’s bet. 🥕

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "update submodules" accurately and concisely reflects the primary change in the changeset, which updates submodule pointers for src/mongo/db/modules/eloq/log_service and src/mongo/db/modules/eloq/tx_service, so it is relevant and clear for a quick scan of history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 60017ba and de1d080.

📒 Files selected for processing (2)
  • src/mongo/db/modules/eloq/log_service (1 hunks)
  • src/mongo/db/modules/eloq/tx_service (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (2)
  • src/mongo/db/modules/eloq/tx_service
  • src/mongo/db/modules/eloq/log_service

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 093df1a and 60017ba.

📒 Files selected for processing (3)
  • src/mongo/db/modules/eloq/log_service (1 hunks)
  • src/mongo/db/modules/eloq/store_handler (1 hunks)
  • src/mongo/db/modules/eloq/tx_service (1 hunks)
🔇 Additional comments (2)
src/mongo/db/modules/eloq/tx_service (1)

1-1: LGTM: submodule pointer bump; please verify SHA exists upstream and CI submodule init is in place.
No code changes here. Just ensure the referenced commit is reachable and CI uses --recursive submodule checkout.

Run this to confirm the SHA exists on the submodule remote:

src/mongo/db/modules/eloq/store_handler (1)

1-1: Submodule pointer update LGTM — confirm intent & CI recursion

All three eloq submodules moved in this PR: log_service b85326f97b62 → eec3b2ba9950; store_handler e0e4ef07c3a9 → 12155c653f1c; tx_service 16f3cf1d6aab → 575b5609f555. Confirm these advances were intentional and that CI runs git submodule update --init --recursive (or submodule.recurse=true).

@MrGuin MrGuin merged commit b6faa65 into eloqdata:main Sep 23, 2025
2 checks passed
@MrGuin MrGuin deleted the ddl_log_ng_leader branch September 23, 2025 06:05
zhangh43 pushed a commit to zhangh43/eloqdoc that referenced this pull request Sep 28, 2025
This was referenced Nov 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants