adapt to boost ucontext for asan

[thweetkomputer]

Summary by CodeRabbit

• Chores
  • Updated internal dependencies

No user-facing changes in this release.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Walkthrough

Submodule pointer in src/mongo/db/modules/eloq/data_substrate updated from commit 8dce439e5e0c668da292e11486f42fd470cd19d4 to commit 4943d80ab4623bf8a324d22def1d12e51fc4aadf, enabling the project to reference the latest data substrate implementation.

Changes

Cohort / File(s)	Summary
Submodule Update src/mongo/db/modules/eloq/data_substrate	Submodule pointer advanced to newer commit

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

• update submodule:add parameter to reuse local files #393 — Updates the same data_substrate submodule pointer to a different commit
• update submoulde #375 — Modifies the same data_substrate submodule pointer to track a new commit
• update subm #386 — Updates the same data_substrate submodule pointer to a different target commit

Suggested labels

trigger-ci

Suggested reviewers

• lzxddz

Poem

🐰 A tiny hop forward, one commit at a time,
The substrate now points to something sublime,
Dependencies dance to a newer beat,
Small changes make integration complete! 🌱

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'adapt to boost ucontext for asan' is specific and relates to the changeset, which updates a submodule pointer for the data_substrate module. However, the title is somewhat technical and assumes familiarity with the project context (what 'boost ucontext' and 'asan' refer to), and does not clearly convey what the practical impact or main change is.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment

---

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 3220e86 and 00ffc8f.

📒 Files selected for processing (1)

• src/mongo/db/modules/eloq/data_substrate

🧰 Additional context used

🧠 Learnings (2)

📓 Common learnings

Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.

Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 211
File: src/mongo/db/modules/eloq/cmake/build_eloq_log_service.cmake:26-80
Timestamp: 2025-09-25T12:24:06.434Z
Learning: The user githubzilla implemented a fix in commit fe98aaf to address the MEMORY state incorrectly triggering RocksDB discovery in build_eloq_log_service.cmake. This was a control flow issue where MEMORY builds were falling into an else branch that still attempted RocksDB discovery.

Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: concourse/scripts/main.ent.bash:38-39
Timestamp: 2025-11-28T10:52:25.527Z
Learning: In the eloqdoc enterprise build (main.ent.bash), eloq_log_service is fetched separately as the resource `eloq_logservice_src` in the pipeline (main.ent.yml) and then symlinked into the data_substrate directory structure at build time using `ln -s $WORKSPACE/eloq_logservice_src eloq_log_service`. This is the intended architecture for placing eloq_log_service within data_substrate in the enterprise configuration.

📚 Learning: 2025-11-28T10:55:21.020Z

Learnt from: githubzilla
Repo: eloqdata/eloqdoc PR: 279
File: src/mongo/db/modules/eloq/CMakeLists.txt:54-55
Timestamp: 2025-11-28T10:55:21.020Z
Learning: In src/mongo/db/modules/eloq/CMakeLists.txt, the CMake options EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, and STATISTICS are used by the data_substrate submodule build system and should be retained as configuration interface options.

Applied to files:

• src/mongo/db/modules/eloq/data_substrate

🔇 Additional comments (1)

src/mongo/db/modules/eloq/data_substrate (1)

1-1: Build system properly configured for ASAN and CMake options are retained.

The parent CMakeLists.txt has ASAN support fully configured: when USE_ASAN=ON, the build will apply -fsanitize=address globally to CMAKE_CXX_FLAGS, CMAKE_EXE_LINKER_FLAGS, and CMAKE_SHARED_LINKER_FLAGS. The submodule will automatically inherit these flags through add_subdirectory(data_substrate). Additionally, all three CMake options (EXT_TX_PROC_ENABLED, FORK_HM_PROCESS, STATISTICS) are present and active.

However, the BOOST_USE_ASAN preprocessor definition is not explicitly set via add_compile_definitions() in the parent CMakeLists.txt. If the data_substrate submodule includes Boost.Context headers directly (rather than relying on compile flags alone), it may need this macro defined. Verify whether the submodule's build system defines it internally or if it should be added to the parent configuration.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[githubzilla]

+1