Skip to content

Don't save deleted records into data_store if mvcc is not enabled on RangePartition#136

Merged
lzxddz merged 1 commit intoeloqdata:eloq-10.6.10from
lzxddz:update-putall
Oct 11, 2025
Merged

Don't save deleted records into data_store if mvcc is not enabled on RangePartition#136
lzxddz merged 1 commit intoeloqdata:eloq-10.6.10from
lzxddz:update-putall

Conversation

@lzxddz
Copy link
Collaborator

@lzxddz lzxddz commented Oct 10, 2025

Summary by CodeRabbit

  • Chores
    • Updated an internal storage subcomponent to a newer revision.
    • No functional, UI, or behavioral changes for end-users.
    • Routine maintenance only; no action required from users or administrators.
    • No expected impact on performance or compatibility.

@lzxddz lzxddz self-assigned this Oct 10, 2025
@coderabbitai
Copy link

coderabbitai bot commented Oct 10, 2025

Caution

Review failed

The pull request is closed.

Walkthrough

Updated the storage/eloq/store_handler submodule pointer from commit db720400d195c7164c386e13ca2811fa668123de to b3e65901f34d6580617fea9ce89adec0426f4aae. No local code, API, or control-flow changes in this repository.

Changes

Cohort / File(s) Summary of Changes
Submodule pointer update
storage/eloq/store_handler
Advanced submodule commit from db720400d1... to b3e65901f3...; no local source changes.

Sequence Diagram(s)

(Skipped — change is a submodule pointer update with no control-flow or feature modifications.)

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

  • Eloq purger test support #134 — Also updates the storage/eloq/store_handler submodule pointer to a different commit; closely related pointer-management change.
  • update subm #119 — Appears to perform a submodule pointer update for storage/eloq/store_handler to another commit.
  • update subm #117 — Modifies submodule pointers including storage/eloq/store_handler (and other eloq submodules) in a related update.

Poem

I twitch my nose and nudge the trail,
A tiny hop, a quiet sail.
No functions bent, no threads untied,
Just a new commit where pointers glide. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Title Check ⚠️ Warning The title describes a behavior change to skip saving deleted records when MVCC is disabled on RangePartition, but the only change in this pull request is an update to a submodule reference with no functional or behavioral modifications detected. Update the pull request title to reflect the submodule reference update or include the actual implementation of the described behavior change so the title matches the content of the changeset.
✅ Passed checks (2 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 79866da and 514cc56.

📒 Files selected for processing (1)
  • storage/eloq/store_handler (1 hunks)

Warning

Review ran into problems

🔥 Problems

Git: Failed to clone repository. Please run the @coderabbitai full review command to re-trigger a full review. If the issue persists, set path_filters to include or exclude specific files.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lzxddz lzxddz merged commit e0900d4 into eloqdata:eloq-10.6.10 Oct 11, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants