Fix compile error

[lzxddz]

Summary by CodeRabbit

• Chores
  • Updated an internal submodule to a newer commit to keep components current.
  • Extended the ELOQ data store build for the cloud S3 variant to include new S3 file handling support, improving cloud-backed data store behavior.

_{✏️ Tip: You can customize this high-level summary in your review settings.}

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

Updated the storage/eloq/store_handler submodule pointer and added store_handler/eloq_data_store_service/s3_file_downloader.cpp to storage/eloq/CMakeLists.txt when WITH_DATA_STORE is ELOQDSS_ROCKSDB_CLOUD_S3.

Changes

Cohort / File(s)	Change Summary
Submodule Update storage/eloq/store_handler	Submodule commit reference changed from 9fc13524deb51390850482456d2a0b524a1e83ba to 4def573ca78dab2f59039f0c10e05d5f429e413e.
Build Configuration storage/eloq/CMakeLists.txt	When WITH_DATA_STORE equals ELOQDSS_ROCKSDB_CLOUD_S3, added store_handler/eloq_data_store_service/s3_file_downloader.cpp to MYELOQ_SOURCES.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

• Spot-checks:
  • Confirm s3_file_downloader.cpp exists in the referenced submodule commit and compiles under the ELOQDSS_ROCKSDB_CLOUD_S3 configuration.
  • Verify the submodule pointer targets the intended upstream change and no unintended files were included.

Possibly related PRs

• Fix compile error #169 — updates storage/eloq submodule and adds s3_file_downloader.cpp to the same CMake configuration.
• update subm #119 — updates the storage/eloq/store_handler submodule pointer (related commit changes).
• update subm #117 — also updates the storage/eloq/store_handler submodule and touches S3-related build items.

Suggested reviewers

• liunyl
• xiexiaoy

Poem

🐇 I nibbled at a hash and hopped along the tree,
A pointer moved, a source added for S3,
My paws left prints on build and commit,
Tiny changes, tidy fit —
🥕 a carrot patch for CI to see!

Pre-merge checks and finishing touches

❌ Failed checks (1 inconclusive)

Check name	Status	Explanation	Resolution
Title check	❓ Inconclusive	The title 'Fix compile error' is vague and generic, providing no meaningful information about which compile error was fixed or what changes were made to resolve it.	Provide a more descriptive title that specifies the nature of the compile error, such as 'Add s3_file_downloader.cpp to ELOQDSS_ROCKSDB_CLOUD_S3 build' or 'Update store_handler submodule to fix compilation issues'.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

---

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f98a3fc and 5f13b71.

📒 Files selected for processing (1)

• storage/eloq/store_handler (1 hunks)

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}