Skip to content

Fix out of memory when execute data sync scan#186

Merged
lokax merged 3 commits intomainfrom
yf-scan-full
Nov 11, 2025
Merged

Fix out of memory when execute data sync scan#186
lokax merged 3 commits intomainfrom
yf-scan-full

Conversation

@lokax
Copy link
Collaborator

@lokax lokax commented Nov 4, 2025

Summary by CodeRabbit

  • Bug Fixes
    • Fixed initialization of an internal error state during reset to prevent indeterminate error conditions. This reduces sporadic failures and improves stability and reliability. No public APIs were changed.

@coderabbitai
Copy link

coderabbitai bot commented Nov 4, 2025

Walkthrough

Explicitly initialize FillStoreSliceCc::err_code_ to NO_ERROR in FillStoreSliceCc::Reset. Also apply a non-functional formatting change to the inline definition of DataStoreHandler::ScheduleTimerTasks() (space before braces) in the header.

Changes

Cohort / File(s) Summary
Error state initialization
src/cc/cc_req_misc.cpp
Initialize err_code_ member to NO_ERROR in FillStoreSliceCc::Reset.
Whitespace/formatting
include/store/data_store_handler.h
Adjust whitespace in inline method definition: ScheduleTimerTasks() {} (space before braces); no behavioral change.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~5 minutes

  • Verify NO_ERROR is the intended default for err_code_ and consistent with surrounding code.
  • Check any code paths that read err_code_ after Reset to ensure expected behavior.
  • Confirm the header formatting change has no unintended preprocessor or ABI effects.

Poem

I nibble at lines and tidy the bed,
I set errors to zero, no ghosts in my thread,
A space for the braces, a calm little tweak—
Code neat as carrots, cozy and sleek. 🐇✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Description check ⚠️ Warning The pull request description is entirely missing, lacking all required template sections including tests, documentation, issue references, RFC links, and test execution confirmation. Add a comprehensive pull request description following the template: confirm tests added, document changes, reference the issue with 'fixes eloqdb/tx_service#186', note any RFC links, and verify test suite passes.
✅ Passed checks (1 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Fix out of memory when execute data sync scan' accurately describes the primary issue being addressed by the changes.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch yf-scan-full

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cfe4da3 and 4cb18dc.

📒 Files selected for processing (1)
  • include/store/data_store_handler.h (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • include/store/data_store_handler.h

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@lokax lokax merged commit f4a1afb into main Nov 11, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: The data sync scan fails to execute correctly after the memory is full

3 participants