feat: add eloq_store_root_meta_cache_size to eloq_store_config#377
feat: add eloq_store_root_meta_cache_size to eloq_store_config#377eatbreads wants to merge 4 commits intoeloqdata:mainfrom
Conversation
WalkthroughAdds a global EloqStore root-meta cache-size flag and config fallback/auto-derivation, parses and assigns it to eloqstore configs, subtracts it from node memory accounting before other sizing, and updates the eloqstore submodule pointer. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Possibly related PRs
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Fix all issues with AI agents
In `@store_handler/eloq_data_store_service/eloqstore`:
- Line 1: Update the size-validation and parsing to explicitly reject zero and
absurdly large values and add tests: modify is_valid_size() and parse_size() in
eloq_store_config.cpp to ensure parsed numeric value > 0 and <= a defined
MAX_ROOT_META_CACHE_BYTES (choose a sensible cap or compare to system total
memory via a helper like getTotalSystemMemory()), and ensure unit parsing only
accepts supported units (e.g., B, KB, MB, GB, TB) so unknown units like "PB" are
rejected; then add unit/edge-case tests in eloqstore_config_test (and an
integration test that sets eloq_store_root_meta_cache_size and verifies
EloqStore uses the parsed value) to cover valid cases ("1GB","512MB","2TB") and
invalid cases ("0GB","-1GB","1PB","abc","").
Here are some reminders before you submit the pull request
fixes eloqdb/tx_service#issue_id./mtr --suite=mono_main,mono_multi,mono_basicSummary by CodeRabbit
New Features
Chores
✏️ Tip: You can customize this high-level summary in your review settings.