[BUG] Workflow as activity doesn't work anymore after server restart

[jeanbaptistedalle]

Description

A workflow "Usable as activity" could be used in another workflow but after app stop, it failed with a NotFoundActivity

Steps to Reproduce

1. Detailed Steps:

• Run those two projects from elsa-samples repository : Elsa.Samples.AspNet.Tenants + ElsaStudioBlazorServerWithTenantInRouteApp with at least 3.5.* packages (cf. Upgrade to 3.5 packages elsa-samples#24)
• Create a workflow 1 and check “Usable as activity”
• Publish workflow 1
• Create another workflow 2 that is triggered by a cron (or any other trigger) and that calls the first workflow
• Workflow 2 will start successfully
• Restart the Workflow server
• Workflow 2 will fail because workflow 1 is no longer registered in Elsa’s list of activities, the activity will result in a NotFoundActivity with error "Elsa.Workflows.Exceptions.ActivityNotFoundException: Activity type 'Workflow 1' version '0' could not be found."
• Republish workflow 1, which will be added back to the list of activities. Workflow 2 will succeed again.

2. Reproduction Rate: every time

Expected Behavior

Workflow usable as activity should still be usable after restart.

Actual Behavior

The workflow is not registered in the activity registry as it's done when the workflow changed, not on the app startup.

[sfmskywalker]

Hi @jeanbaptistedalle , thank you for reporting this issue. I have tried these steps with the 3.5.0 RC1 version (released just now), and was unable to reproduce the issue.

Please let me know which version you are seeing this issue with, and if possible, please attach a repro (given that I failed to reproduce the issue with the current description on 3.5.0-rc1).

Thank you.

[jeanbaptistedalle]

I updated the issue with a pull request for elsa-samples and the project I used to reproduce the issue : Elsa.Samples.AspNet.Tenants + ElsaStudioBlazorServerWithTenantInRouteApp with at least 3.5.* packages (cf. elsa-workflows/elsa-samples#24)

[jeanbaptistedalle]

Hi @sfmskywalker did you manage to reproduce this issue ? We still face it and I think the root cause can be that the ActivityRegistry is in singleton, that could not work with multi-tenancy workflows defined as activity

[sfmskywalker]

Hi @jeanbaptistedalle , not yet. Thank you for putting this back on my radar. I have assigned this issue the 3.5.1 milestone to make sure it keeps that way.

[sfmskywalker]

After checking out your PR I had to update some package references and update a few classes to accommodate for breaking API changes, and then tried the repro steps. But, I was not able to see any issues - everything just worked.

I have attached a patch in case you want to try and apply it (I couldn't push to your fork directly).
I'll close this issue for now as "cannot reproduce", but please feel free to reopen and or continue the conversation.

b4fa11.patch