Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some improvements on the final MultiQC reports:
NAvalues will appear. Ifno_bigwigsrule is triggered, the run will still be successful. For this, I forced the Picard step to produce a dummy file, and handle some zero exceptions on the stat summarization steps.NAto make it consistent. Je puts a question mark on empty library sizes, library size estimation returnedNone, so now it is allNAfor everything.stats_summary.txtfile. I don't think it needs to go on the HTML report output maybe as there are a lot of columns already, but it is still nice to have it in the final table - sometimes we want to dig deeper on barcode performance statistics.