Dash cut#11
Merged
elv-reza merged 4 commits intoelv-release-4.4from Nov 22, 2024
Merged
Conversation
Contributor
elv-reza
commented
Nov 22, 2024
elv-reza
commented
- issue: https://github.com/qluvio/content-fabric/issues/3008
- Fix dash cut if some frames are missing in the input file
elv-serban
reviewed
Nov 22, 2024
Comment on lines
+2420
to
+2422
| if (frame_duration_variation >= pkt->duration) | ||
| frame_duration_variation = pkt->duration - 1; | ||
| } |
Contributor
There was a problem hiding this comment.
In the case packet durations are 1501, 1502, this risks to be equal to the shorter frame (1501).
I think a safer option is (pkt->duration / 2 + 1)
Or (pkg->duration - 2)
Contributor
Author
There was a problem hiding this comment.
The key is not going beyond packet duration. The half + one also works.
elv-serban
approved these changes
Nov 22, 2024
elv-peter
pushed a commit
that referenced
this pull request
Jul 23, 2025
* Fix an issue cutting dash segments when there is PTS jumps in the source
elv-serban
pushed a commit
that referenced
this pull request
Feb 23, 2026
* Fix an issue cutting dash segments when there is PTS jumps in the source
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.