Fix SIGFPE in dashenc#8
Merged
elv-reza merged 1 commit intoelv-release-4.4-netint-quadrafrom May 9, 2024
Merged
Conversation
Contributor
elv-reza
commented
May 9, 2024
elv-reza
commented
- Fix SIGFPE in dashenc.c due to total_duration=0
Contributor
|
What happens when that 'if' doesn't execute? What do we get back from dashenc? Can you add that info here with the PR so we know what to expect? |
Contributor
Author
Nothing happens in our case, there is no data and no segments will be generated. It just avoids the crash... |
elv-serban
approved these changes
May 9, 2024
elv-john
pushed a commit
that referenced
this pull request
May 14, 2024
elv-peter
pushed a commit
that referenced
this pull request
Jul 23, 2025
elv-serban
pushed a commit
that referenced
this pull request
Feb 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.