Skip to content

fix(_prepare.el): Resolve infinite recursion in exec-path setup #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jcs090218 merged 2 commits into from
Feb 12, 2023
Merged

fix(_prepare.el): Resolve infinite recursion in exec-path setup #118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5115186
fix(_prepare.el): Resolve infinite recursion in exec-path setup
jcs090218 Feb 12, 2023
35f5a35
changelog
jcs090218 Feb 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ Check [Keep a Changelog](http://keepachangelog.com/) for recommendations on how
* Fix package `xxx` is unavailable issue from Emacs snapshots (#111)
* Fix install `CRLF` EOL (#112)
* fix: Also expose `bin` folder for symlink package (#115)
* Resolve infinite recursion in `exec-path` setup (#118)

## 0.7.x
> Released Sep 08, 2022
Expand Down
7 changes: 4 additions & 3 deletions lisp/_prepare.el
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -191,9 +191,10 @@ the `eask-start' execution.")

(defun eask--update-exec-path ()
"Add all bin directory to `exec-path'."
(dolist (filename (directory-files-recursively package-user-dir directory-files-no-dot-files-regexp nil nil t))
(when (string-suffix-p "bin/" (file-name-directory filename))
(add-to-list 'exec-path (file-name-directory filename) t)))
(dolist (entry (directory-files package-user-dir t directory-files-no-dot-files-regexp))
(when-let* ((bin (expand-file-name "bin" entry))
((file-directory-p bin)))
(add-to-list 'exec-path bin t)))
(delete-dups exec-path))

(defun eask--update-load-path ()
Expand Down