dap-ui: Fixed issue where control icon background was unspecified #513
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This resolves emacs-lsp#462. If a user starts `dap-debug`, dap-mode creates a set of icons used to do common debug actions (step, continue, etc). These icons are created using `propertize` to make the text that displays the images on a background. The existing setting uses the background color from the `fringe` face to set the background of the icon. The return value for the `face-attribute` function is not guaranteed to be specified. When the `:background` is unspecified, the space is made for the icons but nothing is displayed. This PR defines a face to control the background color used for the debug icons. It defaults to using the background color defined in the `fringe` face, but will inherit from the `default` face if the `:background` attribute is unspecified in `fringe`.
yyoncho
approved these changes
Sep 26, 2021
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This resolves #462.
If a user starts
dap-debug, dap-mode creates a set of icons used to do common debug actions (step, continue, etc). These icons are created usingpropertizeto make the text that displays the images on a background.The existing setting uses the background color from the
fringeface to set the background of the icon. The return value for theface-attributefunction is not guaranteed to be specified. When the:backgroundis unspecified, the space is made for the icons but nothing is displayed.This PR defines a face to control the background color used for the debug icons. It defaults to using the background color defined in the
fringeface, but will inherit from thedefaultface if the:backgroundattribute is unspecified infringe.