Skip to content

Conversation

@ericdallo
Copy link
Member

@ericdallo ericdallo commented Apr 25, 2020

  • Fix ci tests
  • change badge for github action badge

@ericdallo ericdallo changed the title Fix seqfirst [DO NOT MERGE YET] Fix seqfirst Apr 25, 2020
@ericdallo ericdallo marked this pull request as ready for review April 25, 2020 15:45
@ericdallo ericdallo changed the title [DO NOT MERGE YET] Fix seqfirst [DO NOT MERGE YET] Fix CI Apr 25, 2020
@ericdallo ericdallo changed the title [DO NOT MERGE YET] Fix CI Fix CI Apr 25, 2020
@ericdallo
Copy link
Member Author

@yyoncho, It's working now.
I don't have permissions, so could you change on repo Settings to run CI GH actions on PRs?

@yyoncho
Copy link
Member

yyoncho commented Apr 25, 2020

I added you as a collaborator. I am not sure where to do that from.

@ericdallo
Copy link
Member Author

ericdallo commented Apr 25, 2020

Thanks for that, I accepted the invitation but I can't access the settings yet :/

image

Maybe a different permission on my invite

@yyoncho
Copy link
Member

yyoncho commented Apr 25, 2020

Can you retry now?

@ericdallo
Copy link
Member Author

ericdallo commented Apr 25, 2020

It shows me the settings, but I can't see the branches section

If you prefer, I can explain the steps to activate this check on PRs feature

@yyoncho
Copy link
Member

yyoncho commented Apr 25, 2020

Sorry, now it should be good. I dint saw that there is a more powerful role than "Admin"

@ericdallo
Copy link
Member Author

No problem, thanks!
Done, If you want to change/customize that latter, it's on Settings -> Branches -> Branch protection rules -> master :)

@ericdallo
Copy link
Member Author

ericdallo commented Apr 25, 2020

For some strange reason this PR is not running the actions, I think because we enabled the checks after the PR was created...
On my fork it's passing normal: https://github.com/ericdallo/lsp-java/actions/runs/87675675

@ericdallo
Copy link
Member Author

Well, I'll merge it and we can check if it's triggered on master.

@ericdallo ericdallo merged commit 4f66649 into emacs-lsp:master Apr 25, 2020
@ericdallo ericdallo deleted the fix-ci branch April 25, 2020 18:42
@ericdallo
Copy link
Member Author

All passing and OK on master :)

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants