lsp-ui-sideline only show the first line of error.

[nasyxx]

I am not sure if it is a bug of the sideline or my wrong config.

The error shows in normal:

The error shows in sideline:

[whirm]

I'm hitting the same issue with ocaml-language-server.

[coreyoconnor]

Looks to be an aspect of lsp-ui-sideline: All but the first line is dropped from the error message. I verified the same behavior with lsp-scala and verified the lsp was sending the full error message.

The change above does a naive loop over the lines in the error message. Naive because this repeatedly calls lsp-ui-sideline--find-line which does not guarantee each subsequent line in the error message actually shows up on subsequent lines in output. XD

Good enough for most situations and only a bit of a puzzle otehrwise. Give it a try and I'll open a PR soon.

[aqxa1]

@coreyconnor I tried your changes with ocaml-language-server and while it's an improvement, the alignment is kind of wonky:

[coreyoconnor]

@thirdeyefunction I think there are two issues there: The first error message line has extra spaces at the end; the use of right justification for the block is questionable.

The first issue should be easy: always trim spaces from each line. I think that's universally applicable.

As for the second, the right justification, not sure if there is a universal treatment. I'm fine with the right justification. In this case tho, with the line being so short and the added spaces, it really stands out.

[coreyoconnor]

This is complete. All recent changes are only rebases. Please merge.

[aqxa1]

I just want to note that this issue is back as of 401e69b, since lsp-ui-sideline-diagnostic-max-lines is now set to 1. Fair enough if the old default causes issues, but if anyone is wondering why it's broken again, that's why. Easy to fix on the config side, thankfully:
(setq lsp-ui-sideline-diagnostic-max-lines 3)
or set through the customize interface.