lsp-ui-doc--hide-frame: dont clear doc buffer on hide #644
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jcs090218 I don't have merge permission on this project so you will have to merge it for me though :D |
|
Just invited you @kiennq |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've already clear the doc buffer on show so no need to clear the doc buffer on hide, the
webkitversion is also not doing that.Don't clear the doc buffer on hide provides another advantage when triggers
lsp-ui-doc--open-markdown-linkwith the keyboard.In that case, there's a race condition that
(point)is calculated after the doc buffer has been cleared, thus there's no link to follow.Not clear the doc buffer on hide resolve that.