Skip to content

emacs25 - indentation & syntax highlighting broken #371

@eoghanmurray

Description

@eoghanmurray

Upon upgrade to emacs25 and installing latest version of php-mode 1.18.3 I've noticed the mode produces incorrect syntax highlighting (and hence incorrectly indents etc.) after code editing of a large file. After I make some edit that messes up syntax highlighting, I have to manually call php-mode to fix syntax highlighting (this takes a number of seconds to execute) only to have the mode break again moments later after my next edit. I've done a git bisect and have traced this breakage back to 86eab80
I've disabled that call to php-syntax-propertize-function in my local version of php-mode and will report back if that has fixed it for good.

I've got one largish file that reliably triggers the breakage upon editing, it's very hard to pin down exactly what combination of code is causing the breakage, but let me know if you can't recreate and I'll try to cobble together some sort of a minimal test case.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions