Implement RPC features

[zonuexe]

https://phpactor.github.io/phpactor/rpc.html

Editor Actions

• return
• return_choice
• echo Refactor by splitting phpactor and phpactor-action #3
• error
• collection Implement phpactor-action-collection #39
• open_file Refactor by splitting phpactor and phpactor-action #3
• close_file Implement phpactor-action-collection #39
• file_references
• input_callback 51f82e8
• information Refactor by splitting phpactor and phpactor-action #3
• replace_file_source

Phpactor Commands

• complete
• class_search
• goto_definition 22e285e
• copy_class Impl phpactor-copy-class and phpactor-move-class #10
• move_class Impl phpactor-copy-class and phpactor-move-class #10
• offset_info
• transform
• class_new
• class_inflect
• references
• extract_constant
• generate_method
• generate_accessor e16cec9
• context_menu Impl phpactor-context-menu command #24
• navigate
• status b6f68f7
• import_class Auto import class after completion #34 by @kermorgant

[zonuexe]

Update. #3

[zonuexe]

Update #10

[zonuexe]

Update #16

[zonuexe]

Update #17

[MarTango]

I'm currently trying to implement context_menu here, however, I'm struggling a lot since it seems to be the case that the function phpactor-action-input-callback is using the wrong callback (this is changed in my branch), and also often provides invalid arguments to the RPC (I believe this is PHPActor's fault, though).

For example:
calling M-x phpactor-context-menu on Book.php L18C24, choosing rename_variable, in my branch causes the error:
user-error: Invalid arguments "current_path" for handler "rename_variable", valid arguments: "path", "source", "offset", "name", "name_suggestion", "scope"

:current_path doesn't seem to be any different to :path, so I'm not sure why phpactor sometimes specifies one instead of the other.

I've also encountered an issue where phpactor provided a parameter which was missing the key choices (when trying to rename variable), causing the function phpactor--action-input-parameters to throw an error.

I hope what I've said makes some kind of sense - I think the fixes will need to be on phpactor's end)

@dantleech any insight?

If I haven't been clear here, please let me know and I can try to clarify.

[dantleech]

current_path is what the context menu needs, however this is mapped to path by Phpactor (you may also be interested in the Handler which will progressively ask for missing information via. RPC callbacks).

What would help is if you had the request and response, if you don't know already this can be easily found by adding the following in a Phpactor config file (e.g. $HOME/.config/phpactor/phpactor.yml`)

rpc.store_replay: true

You can then easily debug the last RPC command sent to Phpactor with:

$ phpactor rpc --replay --verbose

and see the exact request and response.

Let me know if you have any other questions, I'm having a look at getting Emacs running on my side, so might be able to help out.

[zonuexe]

Update #22, Implemented context menu action. (Thanks @dantleech )

And phpactor package is now available on MELPA and MELPA stable.

[zonuexe]

Update #34, Implemented import_class action.
(Thanks @kermorgant, and I invited him as a member of @emacs-php/developers)