issue with phpactor-copy-class

[kermorgant]

phpactor-copy-class used to work well but I just stumbled upon a project where it failed.

{
  "action": "error",
  "parameters": {
    "message": "Could not copy file \"/path/to/project/api/src/Validator/User/Constraints/UniqueEmail.php\" to \"/path/to/project/api/src/Validator/ProductAttribute/Constraints/ValidProductAttribute.php\"",
    "details": "0: Trying to create descendant from absolute path \"/path/to/project/api/src/Validator/User/Constraints/UniqueEmail.php\" that does not lie within context path \"/path-to-other-project\"\n#0 /home/mikael/src/phpactor/vendor/phpactor/source-code-filesystem/lib/Adapter/Git/GitFilesystem.php(79)...

The relevant part is imho does not lie within context path \"/path-to-other-project which for some reason has been used here.

Facts to consider

• I have several projects opened (using projectile + persp)
• the .git folder is not at the root of the php project but in the parent folder

I will try to debug that a bit more later

[kermorgant]

on the other hand, the function I had written for myself some time ago did the job without any complain

(defun php-class-copy ()
  "Copy a class using phpactor"
  (interactive)
  (setq targetpath (read-file-name "Enter new file name:"))
  (let ((default-directory (projectile-project-root)))
    (start-process "phpactor"
                   (get-buffer-create "*phpactor*")
                   "phpactor"
                   "class:copy"
                   (buffer-file-name (window-buffer (minibuffer-selected-window)))
                   targetpath)))

[kermorgant]

There's something wrong with the work dir which is confirmed by phpactor-status output

Phpactor: Info
----
Version: 0c4f9a2 (il y a 2 semaines) Fix-Vim-plugin-documentation-527
Work dir: /path-to-other-project

path-to-other-project refers to a different project than the one of the current buffer

[kermorgant]

Hmm, the error starts here

    (with-current-buffer (get-buffer-create "*Phpactor Input*")
      (erase-buffer)
      (insert json)
      (call-process-region (point-min) (point-max) (phpactor-find-executable) nil output nil "rpc" (format "--working-dir=%s" (phpactor-get-working-dir)))

Phpactor input contains

{"action":"status","parameters":[]}

EDIT : phpactor-get-working-dir does return the correct dir, but the output of call-process-region not

[kermorgant]

ok, I think I found the issue. I was invoking (phpactor-get-working-dir) from the Phpactor Input buffer which gave unreliable results.

-        (output (get-buffer-create "*Phpactor Output*")))
+        (output (get-buffer-create "*Phpactor Output*"))
+        (cwd (phpactor-get-working-dir)))
     (with-current-buffer output (erase-buffer))
     (with-current-buffer (get-buffer-create "*Phpactor Input*")
       (erase-buffer)
       (insert json)
-      (call-process-region (point-min) (point-max) (phpactor-find-executable) nil output nil "rpc" (format "--working-dir=%s" (phpactor-get-working-dir)))
+      (call-process-region (point-min) (point-max) (phpactor-find-executable) nil output nil "rpc" (format "--working-dir=%s" cwd)

Seems this change fixes this issue. I'll probably merge this soon if I do not spot any other issue with it.